Re: [PATCH v3 2/2] regulator: add device tree support for max8997

From: Grant Likely
Date: Tue Mar 13 2012 - 14:18:07 EST


On Tue, 13 Mar 2012 12:14:42 +0530, Thomas Abraham <thomas.abraham@xxxxxxxxxx> wrote:
> On 13 March 2012 09:13, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
> > On Thu, 23 Feb 2012 18:08:08 +0530, Thomas Abraham <thomas.abraham@xxxxxxxxxx> wrote:
> > Otherwise, the patch looks pretty good.  (although seeing the decode function
> > has got me thinking that we need a much better way of decoding the dt data).
>
> The parsing function looks huge since there is lot of data to pick up
> from the dt node.

Oh, I understand that you have to do it this way; I just think the core code
should make it a lot easier. :-)

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/