Re: [PATCH] checkpatch: Suggest pr_<level> over printk(KERN_<LEVEL>

From: Ted Ts'o
Date: Tue Mar 13 2012 - 18:01:47 EST


On Tue, Mar 13, 2012 at 02:55:17PM -0700, Andrew Morton wrote:
>
> mm... probably. It's not a thing I ever bother mentioning in review,
> but I guess pr_foo() is a bit denser, and doing the same thing in two
> different ways is always an irritant.

Sure but if a particular kernel file or subsystem is _not_ using
pr_foo(), having a checkpatch which tries to force everyone to use
pr_foo() is going to be really annoying to me as a maintainer...

- Ted


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/