Re: [PATCH] firmware loader: don't cancel _nowait requests whenhelper is not yet available

[Kay Sievers]

On Wed, Mar 14, 2012 at 01:10, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> On Wednesday, March 14, 2012, Kay Sievers wrote:

>> It is relevant in the sense that the firmware loader should not even
>> know that a uevent *can* cause a usermodehelper exec() if it runs in
>> legacy mode. The firmware loader just has no business in fiddling with
>> the details of driver core legacy stuff. I don't think his warning
>> makes much sense.
>
> But that warning actually triggers for drivers that attempt to use
> request_firmware() during system resume, even though /sbin/hotplug isn't
> used any more.
>
> usermodehelper_is_disabled() means "we are in the middle of system power
> transition" rather than anything else (I agree it should be called
> suspend_in_progress() or something similar these days).

Yeah it's certainly useful to disable the exec() during suspend calls,
much more than using the exec() inhibit flag for the firmware loader
to throw a warning about suspend issues.

Such confusing hacks need at least a comment, that makes this very obvious. :)

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/