Re: [PATCH] Install kernel-page-flags.h
From: Ulrich Drepper
Date: Wed Mar 14 2012 - 05:44:33 EST
On 03/14/2012 03:58 AM, Christoph Hellwig wrote:
I don't think this is a good idea at all. Let's shoot the person who
added that braindead interface ASAP, and replace it with one printing
the flags in ASCII format.
This isn't really realistic. The information is retrieved based on the
PFN using lseek+read from a file descriptor. How is the read supposed
to work in case the record returned is not of a fixed size? Aside,
potentially a lot of these records are to be read and using ASCII
strings will significantly slow things down.
If you have a concrete proposal please go ahead and propose it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/