Re: [PATCH] tile: remove a non-existing header

From: Chris Metcalf
Date: Wed Mar 14 2012 - 15:08:02 EST


On 3/12/2012 10:18 AM, Mauro Carvalho Chehab wrote:
> Btw, the ./arch/tile/configs/tilepro_defconfig doesn't compile even
> with this fix. It fails at arch/tile/include/asm/atomic_64.h because
> atomic64_t is never defined, but it is used there and on other places.

I suspect you may be trying to use tilepro_defconfig with ARCH=tilegx.
It's only valid for ARCH=tilepro, just like tilegx_defconfig is only valid
for ARCH=tilegx. There's some #ifdefs that are supposed to catch this (in
asm-offsets.c) but it's coming too late. I'll move it so it's before all
the #includes so at least it will be the first error that you see!

> Also, while the edac_tile driver seems to be for both Tile GX and Tilepro
> sub-archs, it is not included on tilegx_defconfig. It would make sense
> to add it there, in order to make easier for people to test/use the
> EDAC drivers.

Fixed now in Linus' tree.

--
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/