Re: [PATCH v2 1/3] radix-tree: introduce bit-optimized iterator

[Andrew Morton]

On Thu, 15 Mar 2012 09:51:03 +0400 Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx> wrote:

> > When a c programmer sees a variable called "i", he solidly expects it
> > to have type "int".  Please choose a better name for this guy!
> > Perferably something which helps the reader understand what the
> > variable's role is.
> 
> =) Ok, I can make it "int"

This should be an unsigned type - negative values are meaningless here.

And "i" is simply a poor identifier.  A good identifier is one which
communicates the variable's role.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/