Re: [PATCH] watchdog: Make sure the watchdog thread gets CPU onloaded system
From: Peter Zijlstra
Date: Thu Mar 15 2012 - 12:04:46 EST
On Thu, 2012-03-15 at 11:54 -0400, Don Zickus wrote:
> > > Why did watchdog() reset the scheduling policy seven instructions
> > > before exiting? Seems pointless.
> >
> > It has been introduced by Thomas in cba9bd22. To be honest I don't
> > understand why it makes a sense?
>
> Yeah I noticed that too. I didn't bother questioning it either when
> it
> went in. I just assumed Thomas and Peter know scheduling a lot better
> than I do. :-)
I just dug through my IRC logs and the reason is that running the entire
exit path as a highest priority RT task incurs a latency spike to other
tasks running on the system (313us). Since there's absolutely no point
in running the exit path as a RT task, tglx made it not do that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/