Re: [PATCH 5/7] module: take rcu_read_lock_sched() for /proc read

[Eric Dumazet]

On Thu, 2012-03-15 at 22:48 +0800, Cong Wang wrote:
> In the seq file operations, it still hold module_mutex for just reading
> the module list, switch to rcu_read_lock_sched() too.
> 

Why is it needed ?

1) insmod/rmmod/lsmod is hardly in fast path.

2) after a mutex_lock(), a task is still preemptible
   after rcu_read_lock_sched(), preemption is disabled

   with NR_CPUS=4096, getting module refcounts is _very_ slow

RCU doesnt fit every workload.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/