Re: [PATCH] edac: i5100 fix erroneous define for M1Err

[Mauro Carvalho Chehab]

Em Fri, 17 Feb 2012 11:36:54 +0100
Niklas SÃderlund <niklas.soderlund@xxxxxxxxxxxx> escreveu:

> According to [1] the define for M1Err in the FERR_NF_MEM register is
> wrong. It should be at position 1 not 0.
> 
> [1] Intel 5100 Memory Controller Hub Chipset Doc.Nr: 318378
>     http://www.intel.com/content/dam/doc/datasheet/5100-
>     memory-controller-hub-chipset-datasheet.pdf
> 
> Reported-by: Ba Thang Nguyen <thang.b.nguyen@xxxxxxxxxxxxxx>
> Signed-off-by: Niklas SÃderlund <niklas.soderlund@xxxxxxxxxxxx>
> ---
>  drivers/edac/i5100_edac.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/edac/i5100_edac.c b/drivers/edac/i5100_edac.c
> index bcbdeec..ab2f906 100644
> --- a/drivers/edac/i5100_edac.c
> +++ b/drivers/edac/i5100_edac.c
> @@ -49,7 +49,7 @@
>  #define		I5100_FERR_NF_MEM_M6ERR_MASK	(1 << 6)
>  #define		I5100_FERR_NF_MEM_M5ERR_MASK	(1 << 5)
>  #define		I5100_FERR_NF_MEM_M4ERR_MASK	(1 << 4)
> -#define		I5100_FERR_NF_MEM_M1ERR_MASK	1
> +#define		I5100_FERR_NF_MEM_M1ERR_MASK	(1 << 1)
>  #define		I5100_FERR_NF_MEM_ANY_MASK	\
>  			(I5100_FERR_NF_MEM_M16ERR_MASK | \
>  			I5100_FERR_NF_MEM_M15ERR_MASK | \

Looks fine. I'm applying on my edac -next tree, together with the other fix:

git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac.git linux-next

Cheers,
Mauro

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/