Re: [PATCH v2 22/37] PCI, acpiphp: remove hot-add support of pci host bridge

[Bjorn Helgaas]

On Mon, Mar 12, 2012 at 11:58 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Mon, Mar 12, 2012 at 8:14 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
>> On Sat, Mar 10, 2012 at 12:00 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>>> It causes confusing.
>>
>> "causes confusion."
>>
>>> We may only need acpi hp for pci host bridge.
>>>
>>> Split host bridge hot-add support to another file, and keep acpiphp simple.
>>
>> I think it's a good thing to remove host bridge hotplug from acpiphp;
>> thanks for doing that.
>>
>> However, I think you removed it here, but didn't add it elsewhere
>> until a different patch.  That means we can't bisect across this.  It
>> would be better to do the entire move in a single patch.
>
> do you mean merge patch 22 and 23 together?

Yes, I think so.  You should have a single "move," not separate
patches that "remove" then "add."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/