Re: [PATCH] power, max8998: Include linux/module.h just once in drivers/power/max8998_charger.c

[Paul Gortmaker]

On 12-03-15 01:17 PM, Anton Vorontsov wrote:
> On Mon, Feb 06, 2012 at 01:57:54AM +0000, íëì wrote:
>>> Remove the duplicate.
>>>
>>> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
>>
>> Acked-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> 
> Applied, thanks!

There is already a commit queued in linux-next that deletes
all the duplicates at once.  It just so happens to delete
the other instance vs the one shown here.  So if both
commits are present, then there won't be *any* module.h
left, and the build will fail.  If it is possible, please
just drop this patch, since the treewide duplicate patch
will still have to exist to fix the other instances.

https://lkml.org/lkml/2012/2/29/586

Thanks,
Paul.

> 
>>
>>> ---
>>>  drivers/power/max8998_charger.c |    1 -
>>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/power/max8998_charger.c b/drivers/power/max8998_charger.c
>>> index 9b3f2bf..5c5f281 100644
>>> --- a/drivers/power/max8998_charger.c
>>> +++ b/drivers/power/max8998_charger.c
>>> @@ -21,7 +21,6 @@
>>>  
>>>  #include <linux/module.h>
>>>  #include <linux/err.h>
>>> -#include <linux/module.h>
>>>  #include <linux/slab.h>
>>>  #include <linux/platform_device.h>
>>>  #include <linux/power_supply.h>
>>> -- 
>>> 1.7.9
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/