Re: [PATCH 5/5] Staging: rtl8187se: r8180_dm.c: Fix comments

[Greg KH]

On Thu, Mar 15, 2012 at 05:15:52PM -0400, Andrew Miller wrote:
> On Thu, Mar 15, 2012 at 02:08:56PM -0700, Greg KH wrote:
> > On Thu, Mar 15, 2012 at 04:49:23PM -0400, Andrew Miller wrote:
> > > On Thu, Mar 15, 2012 at 10:34:05PM +0300, Dan Carpenter wrote:
> > > > On Thu, Mar 15, 2012 at 03:05:21PM -0400, Andrew Miller wrote:
> > > > > -//+by amy 080312
> > > > > +/*{by amy 080312 */
> > > >       ^^^^^^^^^^^^^
> > > > Just remove these comments.  We use version control to see who is
> > > > doing what.
> > > > 
> > > > >  
> > > > > -	//printk("----> DoTxHighPower()\n");
> > > > > +	/* printk("----> DoTxHighPower()\n"); */
> > > > >  
> > > > 
> > > > Also this dead debugging code can be deleted.  There was a bunch of
> > > > it.
> > > > 
> > > > regards,
> > > > dan carpenter
> > > 
> > > Thanks for the advice, If the patch goes through. I'll make another one 
> > > with this changes. If not then I will include them when I revise it.
> > 
> > Send another one on top of this one that removes those unneeded
> > comments, as I've just applied all of the patches in this series.
> > 
> > thanks,
> > 
> > greg k-h
> 
> What about the old code that is commented out?
> There is about one line of code commented out per
> two line of code.

Just delete it, it's obviously not being used :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/