Re: [PATCH 13/35] Disintegrate asm/system.h for M68K [ver #2]

From: Greg Ungerer
Date: Thu Mar 15 2012 - 21:06:35 EST



Hi David,

On 16/03/12 06:18, David Howells wrote:
Greg Ungerer<gerg@xxxxxxxxxxxx> wrote:
This breaks compilation for m68k targets with:

CC net/ipv4/ip_input.o
In file included from
/home/gerg/new-wave.320/linux-3.x/arch/m68k/include/asm/system.h:3:0,
from net/ipv4/ip_input.c:116:
/home/gerg/new-wave.320/linux-3.x/arch/m68k/include/asm/cmpxchg.h: In function
æ__xchgÆ:
/home/gerg/new-wave.320/linux-3.x/arch/m68k/include/asm/cmpxchg.h:33:3: error:
implicit declaration of function æBUGÆ

The old system.h included linux/kernel.h which includes asm/bug.h.
Just including asm/bug.h here in cmpxchg.h is not enough to fix it.
If you include linux/kernel.h though it compiles cleanly.

Which targets, btw?

Looks to be all the non-MMU ones.

So that is the following defconfigs: m5208evb, m5249evb m5272c3,
m5275evb, m5307c3 and m5407c3. For example this configure line:

make ARCH=m68k CROSS_COMPILE=m68k-uclinux- m5208evb_defconfig

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@xxxxxxxxxxxx
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/