Re: [PATCH] Replace IS_ENABLED(CONFIG_FCOE) in linux/netdevice.h

[Tony Breeds]

On Fri, Mar 16, 2012 at 12:55:45AM +0000, Ben Hutchings wrote:
> On Fri, 2012-03-16 at 11:30 +1100, Tony Breeds wrote:
> > On platforms that (or configs that do not have PCI support building any
> > code that includes linux/netdevice.h we see the following warnings:
> > 
> > include/linux/netdevice.h:964:1: warning: "__enabled_CONFIG_FCOE" is not defined [-Wundef]
> > include/linux/netdevice.h:964:1: warning: "__enabled_CONFIG_FCOE_MODULE" is not defined [-Wundef]
> > 
> > In the case of this file we can trivially fallback to the old school
> >  #if defined(...) syntax.
> [...]
> 
> The script that generates those symbols should be fixed instead.

Sorry all, Yes this patch is bogus.

The platform was seeing this error wasn't sourceing
drivers/scsi/Kconfig, so those symbols will never be defined.  I imagine
that's pretty rare.

Yours Tony

Attachment: pgp00000.pgp
Description: PGP signature