Re: [PATCH 0/6] Add a per-dimm structure

From: Greg KH
Date: Fri Mar 16 2012 - 11:31:42 EST


On Fri, Mar 16, 2012 at 11:07:10AM -0300, Mauro Carvalho Chehab wrote:
> Em 16-03-2012 09:07, Mauro Carvalho Chehab escreveu:
> > Em 16-03-2012 08:15, Borislav Petkov escreveu:
> >> Lemme save you all the trouble:
> ...
> > Anyway, I wrote the patches for it already after Greg's email.
> > I'm just about to test them.
>
> And they're already working.
>
> The patches are (will be, after mirror sync) at:
> git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac.git hw_events_v8
>
> There are just two new patches on it (and some bug fix patches got fold
> to simplify their review):
>
> c316427 edac: preserve the current EDAC sysfs API on a separate file
>
> - Just copies the edac_mc_sysfs.c as edac_mc_sysfs_legacy.c,
> in order to preserve the ABI before the changes;
>
> 22790f1 edac: Convert edac mc to use struct device
>
> - Fixes edac_mc_sysfs_legacy.c with the changes at the struct,
> and converts edac_mc_sysfs to use struct device.
>
> There are still a few adjustments to do, so this is not a final version,
> but the patch is already doing what's expected.
>
> I decided to code the ras functions it as a new class, under:
> /sys/class/ras

Ah, you really shouldn't be creating new classes in the kernel either,
sorry. Why is this needed, and you can't just use a bus and struct
device in the place where the kobjects were in the tree?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/