Re: [PATCH] Remove references to /etc/modprobe.conf

[Lucas De Marchi]

Hi Takahashi,

On Fri, Mar 16, 2012 at 11:51 AM, Takashi Iwai <tiwai@xxxxxxx> wrote:
> At Fri, 16 Mar 2012 11:41:16 -0300,
> Lucas De Marchi wrote:
>>
>> Usage of /etc/modprobe.conf file was deprecated by module-init-tools and
>> is no longer parsed by new kmod tool. References to this file are
>> replaced in Documentation, comments and Kconfig according to the
>> context.
>>
>> There are also some references to the old /etc/modules.conf from 2.4
>> kernels that are being removed.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxxxxxxx>
>
> It's nice to correct the document, but the change like
>
> -  /etc/modprobe.conf to ensure that the aoe module is loaded when
> +  /etc/modprobe.d/aoe.conf to ensure that the aoe module is loaded when
>
> might be misleading since it looks as if the fixed config file name
> must be used.

What text do you prefer here? I used a mix of them throughout the
patch. Generally when text said it was giving an example I used a
fixed filename. Otherwise I used "/etc/modprobe.d/*.conf" or "a
configuration file in /etc/modprobe.d/"


> Also, the config file name should be with a number prefix.  At least,
> it's recommended so in the recent distros to determine the loading
> order.  However, which number to be used depends on pretty much on the
> distribution.
>
> So, from both points, it'd be better to mention that it's an example
> file name.

Could you rephrase my change so I include it in a v2 patch?

Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/