Re: [RFC] firmware loader: retry _nowait requests when userhelper is not yet available

From: Rafael J. Wysocki
Date: Sun Mar 18 2012 - 08:18:00 EST


On Sunday, March 18, 2012, Linus Torvalds wrote:
> On Sat, Mar 17, 2012 at 5:29 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> >
> > The patch below (untested) goes slightly into that direction, although not as
> > far as to modify fw_create_instance(). It does, however, split
> > _request_firmware() into "prepare", "load" and "cleanup" parts and moves
> > the usermodehelper check along with the read-locking of umhelper_sem down
> > to the callers, ie. request_firmware() and request_firmware_work_func().
>
> Looks fairly reasonable to me from a quick read-through, and the code
> seems to make sense.

Thanks!

I'll split it into a series of patches, then, and post for testing.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/