Re: [PATCH 2/9] ext4: Use pr_fmt and pr_<level>

[David Miller]

From: "Ted Ts'o" <tytso@xxxxxxx>
Date: Mon, 19 Mar 2012 00:34:20 -0400

> Things like printk(KERN_INFO, ...) are quite well established, and
> changing really doesn't add any value.

It also allows you to modify pr_fmt at the top of the file or
elsewhere and have it influence the output, as just one example
of how it's better.

As a maintainer you can only take one of two positions:

1) Accept all properly written patches that convert code over to use
   the new and recommended way of doing things, such as pr_info() et
   al.

2) Advocate on linux-kernel to remove these new interfaces or improve
   them if you don't find them suitable, and then once suitable go
   back to #1.

Just keeping things the way they are because you simply feel like it
is really not acceptable Ted.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/