[PATCH V1] mfd: rc5t583: Build only if I2C config is selected to y.

From: Laxman Dewangan
Date: Mon Mar 19 2012 - 02:20:26 EST


The rc5t583 driver requires the I2C and regmap apis to
link. But linking fails if I2C is selected as loadable
module, not the module link with binary.
Fixing this error as rc5t583 driver should be built only
if CONFIG_I2C=y.

Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
---
Fixing build error reported by Stephen Rothwell:
After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/built-in.o: In function `rc5t583_i2c_init':
rc5t583.c:(.init.text+0xb3db): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `rc5t583_i2c_probe':
rc5t583.c:(.devinit.text+0x8fa0): undefined reference to `regmap_init_i2c'
drivers/built-in.o: In function `rc5t583_i2c_exit':
rc5t583.c:(.exit.text+0x708): undefined reference to `i2c_del_driver'

Caused by commit 1b1247dd75aa ("mfd: Add support for RICOH PMIC
RC5T583"). Presumably some missing Kconfig dependency.


drivers/mfd/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index f118a31..67fdef1 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -849,7 +849,7 @@ config MFD_INTEL_MSIC

config MFD_RC5T583
bool "Ricoh RC5T583 Power Management system device"
- depends on I2C && GENERIC_HARDIRQS
+ depends on I2C=y && GENERIC_HARDIRQS
select MFD_CORE
select REGMAP_I2C
help
--
1.7.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/