Re: [PATCH] xz: make use of BCJ filter also for 32-bit x86kernel

From: Jan Beulich
Date: Mon Mar 19 2012 - 04:04:41 EST


>>> On 16.03.12 at 19:47, Lasse Collin <lasse.collin@xxxxxxxxxxx> wrote:
> On 2012-03-15 Jan Beulich wrote:
>> The ARCH value for 32-bit x86 is not x86, but i?86.
>
> Thanks for noticing this. Is ARCH even the correct variable to use?
> Maybe SRCARCH would be better. Then it would be enough to test for x86,
> if I understand the toplevel Makefile correctly.

Yes, that might be even better (albeit requiring adjustment of the script
should the naming in the source tree ever change again, whereas the
ARCH values are supposedly stable).

> On SPARC, it seems to be possible that ARCH is sparc32 or sparc64 while
> SRCARCH is always sparc, so currently xz_wrap.sh seems to be buggy on
> SPARC too.

Indeed.

Will you get a patch to Linus then to fix all of these in 3.4?

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/