Re: [RFC] firmware loader: retry _nowait requests when userhelper isnot yet available

[James Courtier-Dutton]

On 16 March 2012 23:37, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Mar 16, 2012 at 3:57 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
>> + Â Â Â if (nowait) {
>> + Â Â Â Â Â Â Â int limit = loading_timeout * MSEC_PER_SEC;
>> + Â Â Â Â Â Â Â int timeout = 10; Â/* in msec */
>> +
>> + Â Â Â Â Â Â Â while (usermodehelper_is_disabled()) {
>> + Â Â Â Â Â Â Â Â Â Â Â read_unlock_usermodehelper();
>> +
>> + Â Â Â Â Â Â Â Â Â Â Â msleep(timeout);
>
> Ugh, this is disgusting.
>
> The whole point of nowait was that it's not synchronous - so it should
> just be driven by timers, not some kind of random "while sleep" loop.
>
> And that fw thing already does have a timeout associated with it, and
> quite frankly, the *sane* approach is to do all this not in
> _request_firmware(), but in request_firmware_work_func() - never even
> call _request_firmware() in the first place if the system isn't ready,
> just reset the timeout to retry it again later.
>
> Seriously. The rule should be really simple: nothing should *ever*
> call "request_firmware()" (or the _request_firmware() helper function)
> while the system is not up. That WARN_ON() should remain totally and
> utterly unconditional, and it should *not* be conditional on "nowait"
> or any idiotic crappy hack like that.
>
> If there is an asynchronous thread - and there is, for the _nowait()
> case - that asynchronous thread should set up the timer and retry in
> ten seconds or whatever. It should *not* call 'request_firmware()" and
> expect that to do something special.
>

Could an alternative be a new event/callback to the driver informing
it that the request_firmware() functionallity is present or not.
The driver would then get a callback on each transition from
"request_firmware() present" to/from "request_firmware() absent".
So, on boot up, the driver ".probe" gets called, and only when enough
infrastructure is up and running does the "request_firmware() present"
callback get called.
The question then becomes
Q1: "how do we determine when enough infrastructure is up for
request_firmware() to succeed?"
Now, if that question can actually be answered, I would prefer that
approach, than to each driver starting a timer based request, to keep
requesting every 2 seconds until it works.

Other similar themes:
could be the driver registers an interest in a particular firmware
file in a particular location, and then when the system determines
that that particular file is now readable, it makes a callback to the
driver. It is certainly an easier question to answer than Q1. No
timers needed.
This could be implemented with a "request_firmware(filename)" that
returns imeadiately but adds the filename to the list of firmware
files to look out for.
The driver then gets a callback "here_is_requested_firmware(filename)"
when the system determines that it can read it.
This list could be scanned immediately and after that; only when a
filesystem is mounted, or the user requests a rescan.

Kind Regards

James
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/