Re: [PATCH v7 2/3] clk: introduce the common clock framework

[Saravana Kannan]

On 03/19/2012 11:56 AM, Turquette, Mike wrote:
> On Fri, Mar 16, 2012 at 8:28 PM, Saravana Kannan<skannan@xxxxxxxxxxxxxx>  wrote:
> > On 03/15/2012 11:11 PM, Mike Turquette wrote:
> > > The common clock framework defines a common struct clk useful across
> > > most platforms as well as an implementation of the clk api that drivers
> > > can use safely for managing clocks.
> > >
> > > The net result is consolidation of many different struct clk definitions
> > > and platform-specific clock framework implementations.
> > >
> > > This patch introduces the common struct clk, struct clk_ops and an
> > > implementation of the well-known clock api in include/clk/clk.h.
> > > Platforms may define their own hardware-specific clock structure and
> > > their own clock operation callbacks, so long as it wraps an instance of
> > > struct clk_hw.
> > >
> > > See Documentation/clk.txt for more details.
> > >
> > > This patch is based on the work of Jeremy Kerr, which in turn was based
> > > on the work of Ben Herrenschmidt.
> > >
> > > Signed-off-by: Mike Turquette<mturquette@xxxxxxxxxx>
> > > Signed-off-by: Mike Turquette<mturquette@xxxxxx>
> > > Reviewed-by: Thomas Gleixner<tglx@xxxxxxxxxxxxx>
> > > Tested-by: Andrew Lunn<andrew@xxxxxxx>
> > > Reviewed-by: Rob Herring<rob.herring<at>    calxeda.com>
> > > Cc: Russell King<linux@xxxxxxxxxxxxxxxx>
> > > Cc: Jeremy Kerr<jeremy.kerr@xxxxxxxxxxxxx>
> > > Cc: Arnd Bergman<arnd.bergmann@xxxxxxxxxx>
> > > Cc: Paul Walmsley<paul@xxxxxxxxx>
> > > Cc: Shawn Guo<shawn.guo@xxxxxxxxxxxxx>
> > > Cc: Sascha Hauer<s.hauer@xxxxxxxxxxxxxx>
> > > Cc: Richard Zhao<richard.zhao@xxxxxxxxxx>
> > > Cc: Saravana Kannan<skannan@xxxxxxxxxxxxxx>
> > > Cc: Magnus Damm<magnus.damm@xxxxxxxxx>
> > > Cc: Mark Brown<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> > > Cc: Linus Walleij<linus.walleij@xxxxxxxxxxxxxx>
> > > Cc: Stephen Boyd<sboyd@xxxxxxxxxxxxxx>
> > > Cc: Amit Kucheria<amit.kucheria@xxxxxxxxxx>
> > > Cc: Deepak Saxena<dsaxena@xxxxxxxxxx>
> > > Cc: Grant Likely<grant.likely@xxxxxxxxxxxx>
> > > ---
> >
> >
> > Mike,
> >
> > Thanks for the patches! Glad to see that it's finally getting in! I sent a
> > request for a minor change as a reply to the v5 series (since it had more
> > context). Can you please take a look at that and let me know if you can send
> > out a v8 or a patch on top of this to do that?
>
> Hi Saravana,

Hi Mike,

> I'm not sending a v8 series since Arnd has taken in v7 for the 3.4 merge window.

Yeah, I later realized it might be better to send patches on top of v7.

> I'm formulating a reply to your v5 queries, but I'm not done looking
> at the implications of the initializer stuff.  Lets keep the technical
> discussion in that thread for now.

I saw some responses from you over the weekend but not to mine. So, I 
assumed you were busy with other stuff and I started working on a patch 
on top of v7. I will send that out if I get around to finishing it 
before you do. Hope that's alright with you.

Based on what I have done so far, to me it just looked like a search and 
replace of clk->name with clk->hw.name and similar changes for the rest 
of the fields. It looks like we might be able to remove 
clk_register_mux, clk_register_divider, etc if we go with this. No stong 
opinion about removing those, but they seemed redundant after the 
suggester refactor.

I think it would be okay to just move those init fields into clk_hw and 
not bother with renaming it to clk_initializer (I would prefer, clk_info 
or clk_common) if it makes the match much less invasive.


Thanks,
Saravana

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/