Re: [PATCH v7] sound/soc/lapis: add machine driver for ML7213Carrier Board

[Mark Brown]

On Mon, Mar 19, 2012 at 09:02:05PM +0900, Tomoya MORINAGA wrote:

> +static int ml7213_hw_params(struct snd_pcm_substream *substream,
> +			    struct snd_pcm_hw_params *hw_params)
> +{

> +	default:
> +		pr_err("%s: Failed not support format\n", __func__);
> +		return -EINVAL;
> +		break;

No need for the break.

> +	snd_soc_dapm_enable_pin(dapm, "Speaker");
> +	snd_soc_dapm_enable_pin(dapm, "AnalogMIC");
> +	snd_soc_dapm_enable_pin(dapm, "MICBIAS");

Why are you doing thiS?  You never disable these things so if this were
needed you may as well do it on init, but since the default state is
enabled anyway this shouldn't be doing anytihng.

> +static int __init lapis_ml7213_ml26124_init(void)
> +{
> +	return platform_driver_register(&snd_ml7213crb_driver);
> +}
> +module_init(lapis_ml7213_ml26124_init);

module_platform_driver().

> +MODULE_ALIAS("platform: lapis-ml7213ioh-CRB");

No space after the colon.

Attachment: signature.asc
Description: Digital signature