Re: [PATCH v2,1/1] net/hyperv: Fix the code handling tx busy

From: David Miller
Date: Mon Mar 19 2012 - 17:27:20 EST


From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Mon, 19 Mar 2012 14:23:11 -0700

> On Mon, 2012-03-19 at 14:23 -0700, Haiyang Zhang wrote:
>> Instead of dropping the packet, we keep the skb buffer, and return
>> NETDEV_TX_BUSY to let upper layer retry send. This will not cause
>> endless loop, because the host is taking data away from ring buffer,
>> and we have called the stop_queue before returning NETDEV_TX_BUSY.
>>
>> The stop_queue was called in the function netvsc_send() in file
>> netvsc.c, then it returns to rndis_filter_send(), which returns to
>> netvsc_start_xmit() in file netvsc_drv.c. So the NETDEV_TX_BUSY is
>> indeed returned AFTER queue is stopped.
>>
>> Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
>> Reviewed-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
>> ---
>
> Thanks
>
> Acked-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/