Re: [PATCH 1/1] TRIVIAL: mmap.c: fix comment for__insert_vm_struct()

[Andrew Morton]

On Mon, 19 Mar 2012 09:33:24 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:

> (2012/03/17 2:23), Kautuk Consul wrote:
> 
> > The comment above __insert_vm_struct seems to suggest that this
> > function is also going to link the VMA with the anon_vma, but
> > this is not true.
> > This function only links the VMA to the mm->mm_rb tree and the mm->mmap linked
> > list.
> > 
> > Signed-off-by: Kautuk Consul <consul.kautuk@xxxxxxxxx>
> > ---
> >  mm/mmap.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/mm/mmap.c b/mm/mmap.c
> > index da15a79..6328a36 100644
> > --- a/mm/mmap.c
> > +++ b/mm/mmap.c
> > @@ -452,8 +452,8 @@ static void vma_link(struct mm_struct *mm, struct vm_area_struct *vma,
> >  
> >  /*
> >   * Helper for vma_adjust in the split_vma insert case:
> > - * insert vm structure into list and rbtree and anon_vma,
> > - * but it has already been inserted into prio_tree earlier.
> > + * insert vm structure into list and rbtree, but it has
> > + * already been inserted into prio_tree earlier.
> >   */
> >  static void __insert_vm_struct(struct mm_struct *mm, struct vm_area_struct *vma)
> >  {
> 
> 
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>

It's still a bit painful.  I did this:

--- a/mm/mmap.c~mmapc-fix-comment-for-__insert_vm_struct-fix
+++ a/mm/mmap.c
@@ -452,9 +452,8 @@ static void vma_link(struct mm_struct *m
 }
 
 /*
- * Helper for vma_adjust in the split_vma insert case:
- * insert vm structure into list and rbtree, but it has
- * already been inserted into prio_tree earlier.
+ * Helper for vma_adjust() in the split_vma insert case: insert a vma into the
+ * mm's list and rbtree.  It has already been inserted into the prio_tree.
  */
 static void __insert_vm_struct(struct mm_struct *mm, struct vm_area_struct *vma)
 {
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/