Re: [PATCH 1/2] drivers/telephony/ixj.c::add_caps(): don't rely onundefined behaviour

[Jesper Juhl]

On Mon, 19 Mar 2012, Joe Perches wrote:

> On Mon, 2012-03-19 at 23:46 +0100, Jesper Juhl wrote:
> > On Mon, 19 Mar 2012, Joe Perches wrote:
> > > On Mon, 2012-03-19 at 23:37 +0100, Jesper Juhl wrote:
> > > > In drivers/telephony/ixj.c::add_caps() we have several statements like this:
> > > > 
> > > >   	j->caplist[j->caps].handle = j->caps++;
> > > > 
> > > > That's undefined behaviour right there.
> > > telephony has been moved to staging.
> > Since when? Where?
> > In my up-to-date Linus tree with HEAD at 
> > c16fa4f2ad19908a47c63d8fa436a1178438c7e7, that file is is still in 
> > drivers/telephony/, not in staging/...
> > /confused
> 
> In the -next tree.
> 
Ok, seems I've missed that.

> Yes, it's a bug fix, but drivers/telephony is pretty dead.
> 
Dead or not, as long as it's in the tree I think that fixing bugs is 
relevant.
Besides, who knows if/when it'll get ressurrected ;)

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/