Re: [GIT PULL] RCU changes for v3.4

[Paul E. McKenney]

On Mon, Mar 19, 2012 at 05:18:21PM -0700, Linus Torvalds wrote:
> On Mon, Mar 19, 2012 at 8:23 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> >
> > Please pull the latest core-rcu-for-linus git tree from:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-rcu-for-linus
> 
> So Ingo, Paul - I'd really have liked to have some high-level
> user-readable explanation of the changes that I could have put in the
> merge message.
> 
> This is especially true for something like RCU, which (a) seems to be
> continually growing and (b) has had cases of "oops, now it stopped
> working" or "uhhuh, new rules due to new rcu implementations
> interacting differently with spinlocks" etc.
> 
> So when the diffstat summary looks like this:
> 
>   29 files changed, 2965 insertions(+), 642 deletions(-)
> 
> with basically 2000+ new lines (yes, many of them in Documebntation,
> happily, but rcutree grew noticeably too), it really would have been
> nice to have some blurb about what the heck actually happened, ok?

Yep, 2072 of the net additions were in Documentation.

> I'm starting to get explanations in signed tags or in the "please
> pull" messages from a fairly large number of maintainers now, and the
> pulls from Ingo are beginning to look sad and unexplained in contrast.

Many of the change to rcutree.c were due to additions of checks for illegal
use of RCU from idle or offlined CPUs, reworking of the CPU-offline code
path, and fixes to allow use of RCU from idle CPUs (which has always been
illegal, but many uses have nevertheless slipped in over the years).

If it would help, I would be happy to put together an itemized list.
I will of course do so for the next merge window.

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/