Re: [PATCH precise] powerpc/pmac: Fix SMP kernels on pre-core99 UP machines

[Anca Emanuel]

On Tue, Mar 20, 2012 at 9:27 AM, Jeremy Kerr <jeremy.kerr@xxxxxxxxxxxxx> wrote:
> From: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
>
> BugLink: https://bugs.launchpad.net/bugs/959959
>
> The code for "powersurge" SMP would kick in and cause a crash
> at boot due to the lack of a NULL test.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jeremy Kerr <jeremy.kerr@xxxxxxxxxxxxx>
> Reported-By: Adam Conrad <adconrad@xxxxxxxxxx>
> Tested-By: Adam Conrad <adconrad@xxxxxxxxxx>
>
> Cherry-picked from upstream commit
> 78c5c68a4cf4329d17abfa469345ddf323d4fd62
>
> ---
>  arch/powerpc/platforms/powermac/smp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powermac/smp.c b/arch/powerpc/platforms/powermac/smp.c
> index 9b6a820..3394254 100644
> --- a/arch/powerpc/platforms/powermac/smp.c
> +++ b/arch/powerpc/platforms/powermac/smp.c
> @@ -414,7 +414,7 @@ static struct irqaction psurge_irqaction = {
>
>  static void __init smp_psurge_setup_cpu(int cpu_nr)
>  {
> -       if (cpu_nr != 0)
> +       if (cpu_nr != 0 || !psurge_start)
>                return;
>
>        /* reset the entry point so if we get another intr we won't
>
> --
> kernel-team mailing list
> kernel-team@xxxxxxxxxxxxxxxx
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Why not CC: lkml ?

It is on the stable channel ? Upstream link please ?
Now you understand Greg's concerns about maintaining a stable kernel ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/