Re: [PATCHSET] block: remove ioc_*_changed()

[Vivek Goyal]

On Tue, Mar 20, 2012 at 08:53:58AM -0700, Tejun Heo wrote:
> On Tue, Mar 20, 2012 at 11:51:18AM -0400, Vivek Goyal wrote:
> > So this patch still breaks cic->cfqq association in asynchronous
> > manner, when new request comes in. So it will still not solve the
> > problem I reported where after doing IO a task changes cgroup and
> > tries to delete the old cgroup and hangs forever as cic->cfqq is still
> > holding a reference to cgroup?
> 
> That one is gonna have to be fixed from cgroup side.  I already posted
> a RFC patchset (you were cc'd there, I think).  At the moment, the
> blocking thing is memcg's ->pre_destroy() usage.  I'll ping memcg
> people once more and if modification there isn't feasible, will
> implement a workaround in cgroup core.

Ok, now I remember that patchset. So the idea is to delete the cgroup and
drop the creation reference. Internal blkcg object might still be around
and will freed when all the references are gone. Makes sense. Thanks.

Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/