Re: [PATCH v8] sound/soc/lapis: add machine driver for ML7213Carrier Board

From: Mark Brown
Date: Wed Mar 21 2012 - 12:11:48 EST


On Wed, Mar 21, 2012 at 10:15:17AM +0900, Tomoya MORINAGA wrote:

> This machine driver is for
> LAPIS Semiconductor ML7213 Carrier Board + ML26124 Reference Board

This looks good but obviously needs the platform before it can be
merged. One fairly minor thing:

> + mclkfs = clk / params_rate(hw_params);

> + bclkfs = 32;

You no longer use either mclkfs or bclkfs so you could just delete the
code that calculates them - the DAI drivers will work this stuff out for
you now so the machine driver doesn't need to.

Attachment: signature.asc
Description: Digital signature