Re: [RFC 4/4] {RFC} kmod.c: Add new call_usermodehelper_timeout()API

[Oleg Nesterov]

BTW,

On 03/22, Oleg Nesterov wrote:
>
> In any case. I do not know why do we need timeout, but this is
> orthogonal to KILLABLE. Please redo your patches on top of -mm
> tree? Please note that in this case the change becomes trivial.

I have found 1-3 on marc.info, they look fine.

But 2/4 is not exactly correct, it forgets to do argv_free() if
call_usermodehelper_fns() returns -ENOMEM. And I guess you forgot
to remove the unused "struct subprocess_info *info".

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/