Re: [PATCH] memcg: change behavior of moving charges at task move

[KAMEZAWA Hiroyuki]

(2012/03/23 17:53), Johannes Weiner wrote:

> On Fri, Mar 23, 2012 at 09:52:28AM +0900, KAMEZAWA Hiroyuki wrote:
>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>> index b2ee6df..ca8b3a1 100644
>> --- a/mm/memcontrol.c
>> +++ b/mm/memcontrol.c
>> @@ -5147,7 +5147,7 @@ static struct page *mc_handle_present_pte(struct vm_area_struct *vma,
>>  		return NULL;
>>  	if (PageAnon(page)) {
>>  		/* we don't move shared anon */
>> -		if (!move_anon() || page_mapcount(page) > 2)
>> +		if (!move_anon())
>>  			return NULL;
>>  	} else if (!move_file())
>>  		/* we ignore mapcount for file pages */
>> @@ -5158,26 +5158,32 @@ static struct page *mc_handle_present_pte(struct vm_area_struct *vma,
>>  	return page;
>>  }
>>  
>> +#ifdef CONFFIG_SWAP
> 
> That will probably disable it for good :)
> 


Thank you for your good eyes.. I feel I can't trust my eyes ;(


==