Re: [PATCH] x86: Merge x86_32 and x86_64 cpu_idle()

[Ingo Molnar]

* Richard Weinberger <richard@xxxxxx> wrote:

> Both functions are mostly identical, so we can merge them.

Okay, so while looking at the patch I got a bit worried about 
the 'mostly' qualifier ;-)

You could ease that worry by adding an explanation to the 
changelog that itemizes the differences, explains which 
architecture is affected by the changes in what way and gives us 
the warm fuzzy feeling that everything has been considered and 
no ill can come out of using a 'mostly' identical idling 
function in the future.

( You should also pick up Frederic's ack for the next
  submission of this patch. )

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/