Re: [PATCH 21/25] gfs2: use i_op->atomic_create()

[Miklos Szeredi]

On Sat, Mar 24, 2012 at 3:27 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Wed, Mar 07, 2012 at 10:22:38PM +0100, Miklos Szeredi wrote:
>> From: Miklos Szeredi <mszeredi@xxxxxxx>
>>
>> GFS2 doesn't open the file in ->create, but it does check the LOOKUP_EXCL flag
>> in it's create function. ÂConvert to using ->atomic_create and checking O_EXCL
>> so that the nameidata argument is no longer necessary.
>
> It seems odd that we require implementing ->atomic_create even if we
> don't actually do an atomic create but just want to look at the flags.
>
> In fact I wonder if we really need to bother with having ->atomic_create
> and ->create, or if we should have one method (kinda contra my previous
> stance that ->atomic_open and ->atomic_create should be one).
>
> This method then could or could not return a file pointer, but it would
> always be the entry point for creates.

Yes, except I thought of the pain of converting all those returns to
ERR_PTR and left the old ->create instead.

Maybe I should just byte the bullet or do that, having a single return
point for those functions shouldn't be that difficult to do.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/