Re: [PATCH][RESEND] scripts: refactor remove structure forward declarations

[Yang Bai]

ping.

Any comment?

On Mon, Mar 19, 2012 at 1:24 PM,  <hamo.by@xxxxxxxxx> wrote:
> From: Yang Bai <hamo.by@xxxxxxxxx>
>
> Since now it has some problems when generate TAGS,
> refactor this code. Now it will not show the error
> message and will remove declarations using emacs etags.
>
> Signed-off-by: Yang Bai <hamo.by@xxxxxxxxx>
> Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> ---
> Âscripts/tags.sh | Â 11 ++++++++---
> Â1 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index 833813a..2b377fc 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -166,9 +166,6 @@ exuberant()
>    Âall_defconfigs | xargs -r $1 -a             \
>    Â--langdef=dotconfig --language-force=dotconfig     Â\
> Â Â Â Â--regex-dotconfig='/^#?[[:blank:]]*(CONFIG_[[:alnum:]_]+)/\1/'
> -
> - Â Â Â # Remove structure forward declarations.
> - Â Â Â LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' tags
> Â}
>
> Âemacs()
> @@ -233,6 +230,7 @@ if [ "${ARCH}" = "um" ]; then
> Â Â Â Âfi
> Âfi
>
> +remove_structs=
> Âcase "$1" in
> Â Â Â Â"cscope")
> Â Â Â Â Â Â Â Âdocscope
> @@ -245,10 +243,17 @@ case "$1" in
> Â Â Â Â"tags")
> Â Â Â Â Â Â Â Ârm -f tags
> Â Â Â Â Â Â Â Âxtags ctags
> + Â Â Â Â Â Â Â remove_structs=y
> Â Â Â Â Â Â Â Â;;
>
> Â Â Â Â"TAGS")
> Â Â Â Â Â Â Â Ârm -f TAGS
> Â Â Â Â Â Â Â Âxtags etags
> + Â Â Â Â Â Â Â remove_structs=y
> Â Â Â Â Â Â Â Â;;
> Âesac
> +
> +# Remove structure forward declarations.
> +if [ -n $remove_structs ]; then
> + Â ÂLANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' $1
> +fi
> --
> 1.7.9.1
>



-- 
  """
  Keep It Simple,Stupid.
  """

Chinese Name: çæ
Nick Name: Hamo
Homepage: http://hamobai.com/
GPG KEY ID: 0xA4691A33
Key fingerprint = 09D5 2D78 8E2B 0995 CF8EÂ 4331 33C4 3D24 A469 1A33
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/