Re: [PATCH 19/20 v3] sparc/mm/fault_32.c: Port OOM changes todo_sparc_fault

[David Miller]

From: Kautuk Consul <consul.kautuk@xxxxxxxxx>
Date: Mon, 26 Mar 2012 11:32:26 -0400

> +	unsigned int flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE |
> +						  (write ? FAULT_FLAG_WRITE : 0));

Indentation is still wrong.  The "(write ..." on the second line must
line up with the column of the first "F" in "(FAULT_FLAG..." on the
first line.

+			perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ,
+						  1, regs, address);

+			perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MIN,
+						  1, regs, address);

These are still wrong too, for the same reason.

You didn't fix anything.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/