Re: Word-at-a-time dcache name accesses (was Re: .. anybody know ofany filesystems that depend on the exact VFS 'namehash' implementation?)

From: Brian Gerst
Date: Tue Mar 27 2012 - 01:31:37 EST


On Tue, Mar 27, 2012 at 1:02 AM, Dave Jones <davej@xxxxxxxxxx> wrote:
> On Tue, Mar 27, 2012 at 12:42:19AM -0400, Brian Gerst wrote:
>
> Â> > I did only very limited profiling of the 32-bit case, but it's really
> Â> > just four cheap ALU instructions there and didn't really show up at
> Â> > all in the limited profiles I did. And at least I checked that the
> Â> > code worked. I have to say that the advantage of "vectorizing" this
> Â> > code is obviously much less if you can only do 4-byte "vectors", so I
> Â> > didn't actually time whether the patch *improves* anything on x86-32.
> Â> >
> Â>
> Â> This patch is causing my system (x86-64, Fedora 16) to fail to boot
> Â> when DEBUG_PAGEALLOC=n. ÂNo oops, but these error messages were in the
> Â> log for the bad kernel:
>
> I saw this too, it was fixed by f132c5be05e407a99cf582347a2ae0120acd3ad7 for me.
> Does your kernel have that commit ?
>
> Â Â Â ÂDave
>
>

Yes, I see that commit. It looks like I have a different bug that is
preventing the current head from booting then. Bisecting brought me
to this commit instead.

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/