Re: [PATCH] tcp: bind() use stronger condition for bind_conflict
From: Eric Dumazet
Date: Wed Mar 28 2012 - 10:48:36 EST
On Wed, 2012-03-28 at 10:52 -0300, Flavio Leitner wrote:
> On Wed, 28 Mar 2012 00:11:52 +0300
> Alexandru Copot <alex.mihai.c@xxxxxxxxx> wrote:
>
> > diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c
> > index 02dd203..dfc8bc3 100644
> > --- a/net/ipv6/inet6_connection_sock.c
> > +++ b/net/ipv6/inet6_connection_sock.c
> > @@ -28,7 +28,8 @@
> > #include <net/inet6_connection_sock.h>
> >
> > int inet6_csk_bind_conflict(const struct sock *sk,
> > - const struct inet_bind_bucket *tb)
> > + const struct inet_bind_bucket *tb,
> > + int relax)
>
> Same here
> Maybe you can wait for more feedbacks before spin another patch
> version just to fix that.
>
Also 'int relax' should be 'bool relax'... 1/0 -> true/false
Anyway net-next is not open yet...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/