Re: [PATCH] ftrace: Remove a superfluous check
From: Steven Rostedt
Date: Thu Mar 29 2012 - 13:23:58 EST
On Thu, 2012-03-29 at 19:17 +0200, John Kacur wrote:
>
> It looks okay to me. Technically it's not functionally equivalent though,
> because now when __register_ftrace_function is called directly, (in other
> paths), the test has an unlikely there. See what Steven says, otherwise,
> you can have my reviewed by.
Unlikely()s shouldn't affect things functionally, its just an
optimization hint.
Also, this check is unlikely to be true, so the hint is valid here.
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/