Re: [patch] blkcg: change a spin_lock() to spin_lock_irq()

From: Jens Axboe
Date: Thu Mar 29 2012 - 14:57:41 EST

Next message: Vaibhav Nagarnaik: "Re: [PATCH 4/6] trace: trace syscall in its handler not from ptrace handler"
Previous message: Thomas Gleixner: "Re: [PATCH v2 1/3] IRQ: introduce irq_do_set_affinity() to reduceduplicated code"
In reply to: Dan Carpenter: "[patch] blkcg: change a spin_lock() to spin_lock_irq()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 2012-03-29 20:51, Dan Carpenter wrote:
> Smatch complains that we re-enable IRQs twice. It looks like we forgot
> to disable them here on the spin_trylock() failure path. This was added
> in 9f13ef678e "blkcg: use double locking instead of RCU for blkg
> synchronization".

Thanks, that is indeed a screwup. Fix applied.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Vaibhav Nagarnaik: "Re: [PATCH 4/6] trace: trace syscall in its handler not from ptrace handler"
Previous message: Thomas Gleixner: "Re: [PATCH v2 1/3] IRQ: introduce irq_do_set_affinity() to reduceduplicated code"
In reply to: Dan Carpenter: "[patch] blkcg: change a spin_lock() to spin_lock_irq()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]