Re: [PATCH 02/13] edac: move dimm properties to struct memset_info

From: Mauro Carvalho Chehab
Date: Fri Mar 30 2012 - 09:23:17 EST


Em 30-03-2012 10:10, Borislav Petkov escreveu:
> Please don't call it 'memset_info' - this is misleading beyond belief.
>
> Hmm, what struct memset_info - where the hell is this? It is nowhere to
> be seen in the patches following that one too, WTF?

s/memset_info/dimm_info/

Sorry, I forgot to rename the patch name on the rebase I've renamed
this field (rebase 8?).

> On Thu, Mar 29, 2012 at 01:45:35PM -0300, Mauro Carvalho Chehab wrote:
>> On systems based on chip select rows, all channels need to use memories
>> with the same properties, otherwise the memories on channels A and B
>> won't be recognized.
>>
>> However, such assumption is not true for all types of memory
>> controllers.
>>
>> Controllers for FB-DIMM's don't have such requirements.
>>
>> Also, modern Intel controllers seem to be capable of handling such
>> differences.
>>
>> So, we need to get rid of storing the DIMM information into a per-csrow
>> data, storing it, instead at the right place.
>>
>> The first step is to move grain, mtype, dtype and edac_mode to the
>> per-dimm struct.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/