Re: [PATCH 3/8] ext2: write superblock only once on unmount

[Jan Kara]

On Wed 21-03-12 18:14:30, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
> 
> Currently on unmount if we are mounted R/W, we first write the superblock to
> the media if it is dirty, and then write it again, which is not optimal. This
> patch makes ext2 write the superblock on unmount less times.
  Looks good. I've added the patch to my tree.

									Honza
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
> ---
>  fs/ext2/super.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 0090595..d141758 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -130,9 +130,6 @@ static void ext2_put_super (struct super_block * sb)
>  
>  	dquot_disable(sb, -1, DQUOT_USAGE_ENABLED | DQUOT_LIMITS_ENABLED);
>  
> -	if (sb->s_dirt)
> -		ext2_write_super(sb);
> -
>  	ext2_xattr_put_super(sb);
>  	if (!(sb->s_flags & MS_RDONLY)) {
>  		struct ext2_super_block *es = sbi->s_es;
> -- 
> 1.7.7.6
> 
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/