Re: [PATCH 3/4] block: replace rssd_disk_name_format() to disk_name_format()

[Ren Mingxin]

 On 03/31/2012 07:54 AM, Asai Thambi Samymuthu Pattrayasamy 
(asamymuthupa) [CONT - Type 2] wrote:
> On 3/30/2012 2:53 AM, Ren Mingxin wrote:
>
> >   Currently, block core has been supplied "disk_name_format()", so
> > we should remove duplicate function "rssd_disk_name_format()"
> > and use the new function to format rssd disk names.
> >
> > Signed-off-by: Ren Mingxin<renmx@xxxxxxxxxxxxxx>
> > ---
> >   mtip32xx.c |   33 +--------------------------------
> >   1 file changed, 1 insertion(+), 32 deletions(-)
>
> Looks fine.
>
> Should the subject be "mtip32xx: ..." instead of "block: ..."? I
> understand "block:" as relating to block core. I am fairly new here. If
> "block:" can be used for block drivers too, that is fine too.

Good idea! Will be fixed in the next version.

--
Thanks,
Ren

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/