Re: [tip:timers/core] proc: stats: Use arch_idle_time for idle andiowait times if available

[Martin Schwidefsky]

On Fri, 30 Mar 2012 15:54:55 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, 30 Mar 2012 06:58:25 -0700
> tip-bot for Martin Schwidefsky <schwidefsky@xxxxxxxxxx> wrote:
> 
> > Commit-ID:  cb85a6ed67e979c59a29b7b4e8217e755b951cf4
> > Gitweb:     http://git.kernel.org/tip/cb85a6ed67e979c59a29b7b4e8217e755b951cf4
> > Author:     Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> > AuthorDate: Fri, 30 Mar 2012 12:23:08 +0200
> > Committer:  Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > CommitDate: Fri, 30 Mar 2012 15:43:33 +0200
> > 
> > proc: stats: Use arch_idle_time for idle and iowait times if available
> > 
> > Git commit a25cac5198d4ff28 "proc: Consider NO_HZ when printing idle and
> > iowait times" changes the code for /proc/stat to use get_cpu_idle_time_us
> > and get_cpu_iowait_time_us if the system is running with nohz enabled.
> > For architectures which define arch_idle_time (currently s390 only)
> > this is a change for the worse. The result of arch_idle_time is supposed
> > to be the exact sleep time of the target cpu and should be used instead
> > of the value kept by the scheduler.
> 
> So it appears that this patch is a superset of "nohz: fix idle ticks in
> cpu summary line of /proc/stat" (below), yes?

"proc:stats: Use arch_idle_time.." goes on top of "nohz: fix idle ticks..".
If the second patch is applied, s390 does not need the first one anymore.
So for s390 the second one is a superset of the first, on x86 the first
patch is the important one.
 
> > Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> > Reviewed-by: Michal Hocko <mhocko@xxxxxxx>
> > Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@xxxxxxxxxxxxxxxxxx>
> > Link: http://lkml.kernel.org/r/20120330122308.18720283@xxxxxxxxxx
> > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> 
> No cc:stable?  Both 09a1d34f8535ecf9 and a25cac5198d date from
> September '11 and 09a1d34f8535ecf9 (at least) was a regression.
 
The regression is fixed by "proc:stats: User arch_idle_time..", the
second patch gets us back the improved values for s390, you could argue
if this is a regression or not.
Anyway I would not complain if both patches are included the stable
releases. 

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/