Re: [PATCH 18/21] blkcg: move blkio_group_conf->weight to cfq

[Tao Ma]

On 04/03/2012 05:49 AM, Tejun Heo wrote:
> Hello,
> 
> On Tue, Apr 03, 2012 at 05:39:23AM +0800, Tao Ma wrote:
>> I guess blkio->weight is a generic way of abstracting the weight between
>> different block cgroups.
> 
> It isn't and can't be.  There's nothing generic about it across
> different policies and it's not even clear what that means.  If the
> user chooses combine, iops limit with cfq weights, what the hell is
> "generic" about that weight?
> 
>> Yes, currently, only cfq uses it, but I am
>> trying to improve Shaohua's original fiops scheduler and add cgroup
>> support to it. So please leave it there so that future scheduler(if
>> other than the fiops scheduler) can use the framework.
> 
> So, if you want to implement a new blkcg policy, add the config
> parameters and export the stats the policy wants *yourself*.  Not
> having clear separation between policies and generic stuff was what
> led us to this yucky mess and there's no way we're going back there.
> So, NO.
Currently weight is just used to calculate the time slice of different
cfq group, right? So why can't it be used to indicate other weight? So
say, if we are just want to use iops to indicate the difference between
different cgroups(100 weight vs 200 weight), so one process will send
100 ios while the other will send 200 ios just for example. We will need
a new iops_weight in your option to be exported?

Thanks
Tao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/