Re: [PATCH 1/2] HID: hid-lg4ff: Use Private Data

From: Jiri Kosina
Date: Mon Apr 02 2012 - 22:15:02 EST


On Mon, 2 Apr 2012, simon@xxxxxxxxxxxxx wrote:

> >> + struct lg4ff_device_entry *uninitialized_var(entry);
> >> + struct lg_drv_data *uninitialized_var(drv_data);
> >
> > You don't need uninitialized_var bloat anymroe, right?
>
> I guess I don't fully understand the 'unitialized_var()' macro, and was
> just following the previous uses in the code.
>
> Google'ing doesn't really help either. Is there a definitive guide as when
> to use and not?

As Jiri Slaby already explained, it's rather a hack to shut up gcc in
cases in which it gets the unused warning wrong.

But even that is considered controversial by some people ...

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/