Re: [PATCH v6 0/2] Ethernet drivers for WIZnet chips

[Eric Dumazet]

On Tue, 2012-04-03 at 16:58 +0600, Mike Sinkovsky wrote:
> Based on original driver from chip manufacturer, but nearly full rewite.
> Tested and used in production with Blackfin BF531 embedded processor.
> 
> Signed-off-by: Mike Sinkovsky <msink@xxxxxxxxxxxxx>
> ---
> v6:
>  - remove (S0_TX_FSR < skb->len) check in TX handler, it doesn't work
>    anyway. Chip can transmit only one frame with MTU 1500 at a time,
>    and tx buffer size is bigger.

So what happens if XXX frames are given to start_xmit() in a flood ?

You removed any flow control, how can this work ?

Device has an infinite queue ?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/