Re: [PATCH 3/5] powerpc: dts: klondike: Add UART nodes

[Josh Boyer]

On Tue, Apr 3, 2012 at 11:57 AM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
> On Mon,  2 Apr 2012 12:09:05 +0530, Tanmay Inamdar <tinamdar@xxxxxxx> wrote:
>> Adding UART nodes in Klondike device tree file.
>>
>> Signed-off-by: Tanmay Inamdar <tinamdar@xxxxxxx>
>> ---
>> :100644 100644 4ff2852... d5bf2e1... M        arch/powerpc/boot/dts/klondike.dts
>>  arch/powerpc/boot/dts/klondike.dts |   24 ++++++++++++++++++++++++
>>  1 files changed, 24 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/powerpc/boot/dts/klondike.dts b/arch/powerpc/boot/dts/klondike.dts
>> index 4ff2852..d5bf2e1 100644
>> --- a/arch/powerpc/boot/dts/klondike.dts
>> +++ b/arch/powerpc/boot/dts/klondike.dts
>> @@ -222,6 +222,30 @@
>>                               #size-cells = <1>;
>>                               ranges;
>>                               clock-frequency = <0>;
>> +
>> +                             UART0: serial@50001000 {
>> +                                    device_type = "serial";
>> +                                    compatible = "ns16550";
>> +                                    reg = <0x50001000 0x00000100>;
>> +                                    virtual-reg = <0x50001000>;
>
> Why do you need virtual-reg?  The kernel should handle all iomapping
> properly without this.

Right.  It's been used for platforms that actually use the
zImage/treeImage wrapper for printf support, but this uses u-boot as
far as I know.  It shouldn't need it.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/