Re: Commit 8ef874bfc7296fa206eea2ad1e8a426f576bf6f6 has broken sscommand

[Eric Dumazet]

On Wed, 2012-04-04 at 11:44 +0200, Eric Dumazet wrote:
> On Wed, 2012-04-04 at 05:24 -0400, David Miller wrote:
> > From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> > Date: Wed, 04 Apr 2012 11:07:43 +0200
> > 
> > > On Wed, 2012-04-04 at 18:03 +0900, Kusanagi Kouichi wrote:
> > >> Since commit 8ef874bfc7296fa206eea2ad1e8a426f576bf6f6 ("sock_diag:
> > >> Move the sock_ code to net/core/"), ss command from iproute package
> > >> doesn't work if INET_DIAG is not enabled.
> > >> 
> > >> $ ss
> > >> State       Recv-Q Send-Q                                             Local Address:Port                                                 Peer Address:Port
> > >> TCPDIAG answers: Operation not supported
> > >> --
> > > 
> > > Try to update your iproute2 package ?
> > 
> > Well, he doesn't INET_DIAG enabled in his kernel, so no matter what
> > iproute2 version he uses it won't work :-)
> 
> iproute2 misc/ss.c has a fallback using /proc/net/tcp
> 
> Dont know when this broke.
> 
> I guess we should fix ss to cope INET_DIAG being disabled.
> 
> tcp_show_netlink() should return -1 instead of 0
> 

Kusanagi Kouichi is right. Commit 8ef874bfc72 apparently changed things
since socket(AF_NETLINK, SOCK_RAW, NETINK_INET_DIAG) doesnt fail
anymore...



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/