Re: [PATCH v2] gpio: Device tree support for LPC32xx

[Arnd Bergmann]

On Tuesday 03 April 2012, Roland Stigge wrote:
> This patch adds device tree support for gpio-lpc32xx.c
> 
> Signed-off-by: Roland Stigge <stigge@xxxxxxxxx>

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>

Just one more comment:

> +#ifdef CONFIG_OF
> +static struct of_device_id lpc32xx_gpio_of_match[] __devinitdata = {
> +	{ .compatible = "nxp,lpc32xx-gpio", },
> +	{ },
> +};
> +#endif
> +
> +static struct platform_driver lpc32xx_gpio_driver = {
> +	.driver		= {
> +		.name	= "lpc32xx-gpio",
> +		.owner	= THIS_MODULE,
> +		.of_match_table = lpc32xx_gpio_of_match,
> +	},
> +	.probe		= lpc32xx_gpio_probe,
> +};

The #ifdef above is not helpful, it will cause a build error in the
of_match_table= assignment. Since the plan for this driver is to
be devicetree-only, it would be appropriate to just remove the
#ifdef, but adding of_match_ptr() is ok too.

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/